fix: use stable, precalculated BFS for tree allocation paths #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbjorge is attempting to deploy a commit to the vilsol's projects Team on Vercel. A member of the Team first needs to authorize it. |
dbjorge
commented
Dec 25, 2024
| @@ -350,6 +350,21 @@ export declare namespace fwd { | |||
| WriteTo(w?: unknown): [number, Error]; | |||
| } | |||
| } | |||
| export declare namespace mod { | |||
There was a problem hiding this comment.
These came in automatically when the typings got regenerated to pick up the updated calculate signature. I wasn't sure if you'd prefer for me to leave them in vs omit them from the PR, I'm fine with whichever you prefer.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 3rd task in #6
Also fixed a few related pre-existing bugs I noticed while testing:
tree_graph_test.goL67). Separated the "active" and "root" inputs to enable the algorithm to better handle this case.To put together the test cases, I also implemented functionality similar to PoB 1's "developer mode" feature to show node IDs as part of their hover tooltips. I'll send that as a separate PR, but if you care to validate the test cases, it'll be much easier to do so using that PR.